Root node should have an assigned node, but remains NULL. Why can't I assign a node to my root?

问题

I'm writing a binary tree in object-oriented format. I've had experience with binary trees before, but it's been a while since I've touched on this. My problem is that I'm unable to assign a node to my root. Every time I check in debugging mode, the root remains NULL. While this is happening, the cur node contains all the information it's assigned.

I've tried making my root private and changing this->root = NULL; to root-> = NULL;. I've also tried making all of my functions public, but it didn't make a difference. I tried declaring root's children to NULL values and name to an empty string as well.

main.cpp

#include <iostream>
#include <string>
#include <fstream>
#include "Friends.h"

using namespace std;

int main() {
    string line;
    ifstream file;
    file.open("friends.txt");

    Friends f;

    while (getline(file, line)) {
        f.insert(f.root, line);
    }
    f.print(f.root);

    system("pause");
    return 0;
}

Friends.cpp

#include "Friends.h"
#include <iostream>
#include <string>

using namespace std;

Friends::Friends() {
    this->root = NULL;
}

Friends::node* Friends::createNode(string& val) {
    node* newNode = new node();
    newNode->left = NULL;
    newNode->right = NULL;
    newNode->name = val;
    return newNode;
}

Friends::node* Friends::insert(node* cur, string& val) {
    if (!cur) {
        cur = createNode(val);
    }
    else if (val < cur->name) {
        insert(cur->left, val);
        return cur;
    }
    else if (val > cur->name) {
        insert(cur->right, val);
        return cur;
    }
    return NULL;
}

void Friends::print(node* cur) {
    if (!cur) {
        return;
    }
    print(cur->left);
    cout << cur->name << endl;
    print(cur->right);
}

Friends.h

#ifndef FRIENDS_H
#define FRIENDS_H

#include <string>

using namespace std;

class Friends {
private:
    struct node {
        string name;
        node* left;
        node* right;
    };
public:
    node* root;
    node* insert(node* cur, string&);
    void print(node* cur);
    Friends();
    node* createNode(string&);
};

#endif

The root node should have a node, but has keeps showing up as a NULL value. It doesn't run with any errors either. It just remains as NULL.

回答1:

change from:

node* insert(node* cur, string&);

to :

node* insert(node* &cur, string&);

should fix

Of course the implementation header should also be changed

来源：https://stackoverflow.com/questions/56678195/root-node-should-have-an-assigned-node-but-remains-null-why-cant-i-assign-a-n

标签

c++

data-structures

binary-tree