calling asynchronous method inside for-loop [duplicate]

Question

This question already has answers here:

What's the best way to iterate over results from an APi, and know when it's finished? (1 answer)

Swift Closures in for loop (1 answer)

How do you run code after an async call finishes and the code is outside of the asyn function in swift3 (1 answer)

Closed last year.

Trying to make my for loop behave synchronously when I am making an asynchronous call in each iteration of the loop. I have a feeling I will need to use Grand Central Dispatch in some way but not sure.

func test(strings: [String], completion: @escaping ((_ value: [String]) -> Void)) {
    var results: [String] = []
    for string in strings {
        Service.shared.fetch(with: string, completion: { (result) in
            results.append(result)
        })
    }
    // this will run before asynchronous method in for-loop runs n times.
    completion(results)
}

Answer 1

You don't need to make this loop synchronous. What you really want is to call completion when you will get all results. You can use this solution (for free):

func test(strings: [String], completion: @escaping ((_ value: [String]) -> Void)) {
    var results: [String] = []  

    for string in strings {
        Service.shared.fetch(with: string, completion: { (result) in
            DispatchQueue.main.async { 
                results.append(result)
                if results.count >= strings.count {
                    completion(results)
                }
            }
        )
    }
}