static counter in c++

Question

I'm trying to create a Data class whose objects each hold a unique ID.

I want the 1st object's ID to be 1, the 2nd to be 2, etc. I must use a static int, but all the objects have the same ID, not 1, 2, 3...

This is the Data class:

class Data
{
private:
   static int ID;
public:
   Data(){
   ID++;
   }
};

How can I do it so the first one ID would be 1, the second would be 2, etc..?

Answer 1

This:

class Data
{
private:
   static int ID;
   const int currentID;
public:
   Data() : currentID(ID++){
   }
};

Besides a static counter, you also need an instance-bound member.

Answer 2

If the ID is static, then it will have the same value for all class instances.

If you want each instance to have sequential id values, then you could combine the static attribute with a class variable, like this:

class Data
{
private:
   static int ID;
   int thisId;
public:
   Data(){
   thisId = ++ID;
   }
};

int Data::ID = 0;

If the application will be multi threaded, then you'll have to synchronize it with something like a pthread mutex.

Answer 3

Initialization of static variable within a function is allowed so a solution can be something like this

 class Data
 {
    private:
    static int ID ()
    {
       static int ID = 0;
       return ID ++;
    }
    int myId;

    public:
    Data(): myId (ID ())
    {      
    }
 };

Answer 4

Each instance of Data needs its own non-static member variable that stores its ID. A static variable can be used to store the last used ID which would be incremented in the constructor of Data.

Instead of a static counter, which is not thread-safe, consider using boost's uuid:

#include <boost/lexical_cast.hpp>
#include <boost/uuid/uuid.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>

using boost::lexical_cast;
using boost::uuids::uuid;
using boost::uuids::random_generator;

std::string id_ = lexical_cast<std::string>((random_generator())());

Answer 5

where is the instance(non static) id here? you need to declare a new instance ID field like this

int m_ID;

then in your constructor do

Data(){m_ID = ::InterlockedIncrement(&ID);}

in an interlocked or other thread-safe way