Spring RestTemplate - async vs sync restTemplate

问题:

I wrote the following code to test the performance of both the sync RestTemplate and AsyncRestTemplate. I just ran it a few times manually on POSTMAN.

We are just passing 10 references into a GET call so that we can return 10 links:

RestTemplate - synchronous and returns in 2806ms:

ArrayList<String> references = new ArrayList<>(); ArrayList<String> links = new ArrayList<>(); RestTemplate restTemplate = new RestTemplate();  restTemplate.getMessageConverters().add(new StringHttpMessageConverter()); for (int i = 0; i < 10; i++) {     ResponseEntity<String> resource = restTemplate.getForEntity(references.get(i), String.class);     links.add(resource.getBody().toString()); } 

RestTemplate - asynchronous and returns in 2794ms:

//Creating a synchronizedList so that when the async resttemplate returns, there will be no concurrency issues List<String> links = Collections.synchronizedList(new ArrayList<String>());  //CustomClientHttpRequestFactory just extends SimpleClientHttpRequestFactory but disables automatic redirects in SimpleClientHttpRequestFactory CustomClientHttpRequestFactory customClientHttpRequestFactory = new CustomClientHttpRequestFactory(); //Setting the ThreadPoolTaskExecutor for the Async calls org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor pool = new org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor(); pool.setCorePoolSize(5); pool.setMaxPoolSize(10); pool.setWaitForTasksToCompleteOnShutdown(true); pool.initialize(); //Setting the TaskExecutor to the ThreadPoolTaskExecutor customClientHttpRequestFactory.setTaskExecutor(pool);  ArrayList<String> references = new ArrayList<>(); ArrayList<String> links = new ArrayList<>(); AsyncRestTemplate asyncRestTemplate = new AsyncRestTemplate(customClientHttpRequestFactory);  restTemplate.getMessageConverters().add(new StringHttpMessageConverter()); for (int i = 0; i < 10; i++) {     Future<ResponseEntity<String>> resource = asyncRestTemplate.getForEntity(references.get(i), String.class);     ResponseEntity<String> entity = resource.get(); //this should start up 10 threads to get the links asynchronously     links.add(entity.getBody().toString()); } 

In most cases, both methods actually return back the results with a very similar time, averaging 2800ms in both async and sync calls.

Am I doing something incorrect as I would have expected the async call to be much faster?

回答1:

The tricky thing with Java Future is that it's not composable and it's really easy to block.

In this case, calling future.get() makes your code block and wait until the response is back. In fact, this approach makes sequential calls and does not leverage the async nature of this RestTemplate implementation.

The simplest way to fix this is to separate it in two loops:

ArrayList<Future<ResponseEntity<String>>> futures = new ArrayList<>();  for (String url : references.get()) {     futures.add(asyncRestTemplate.getForEntity(url, String.class)); //start up to 10 requests in parallel, depending on your pool }  for (Future<ResponseEntity<String>> future : futures) {     ResponseEntity<String> entity = future.get(); // blocking on the first request     links.add(entity.getBody().toString()); } 

Obviously there are more elegant solutions, especially if using JDK8 streams, lambdas and ListenableFuture/CompletableFuture or composition libraries.

回答2:

I would say that you're missing the real benefits of the AsyncRest here. You should add callbacks to each requests you're sending so that the response will be processes only when available.

Indeed, the getForEntity method of an AsyncRestTemplate returns a ListenableFuture to which you can connect a callback task. See the official doc ListenableFuture for further information.

For example in your case it could be:

for (int i = 0; i < 10; i++) {      ListenableFuture<ResponseEntity<String>> response = asyncRestTemplate.getForEntity(references.get(i), String.class);      response.addCallback(new ListenableFutureCallback<ResponseEntity<String>>() {             @Override             public void onSuccess(ResponseEntity<String> result) {                 // Do stuff onSuccess                  links.add(result.getBody().toString());             }              @Override             public void onFailure(Throwable ex) {                 log.warn("Error detected while submitting a REST request. Exception was {}", ex.getMessage());             }         }); } 

文章来源: Spring RestTemplate - async vs sync restTemplate