Calling Javascript function from a C++ callback in V8

匿名 (未验证) 提交于 2019-12-03 01:58:03

问题:

I'm trying to call a registered JS function when a c++ callback is called, but I'm getting a segfault for what I assume is a scoping issue.

 Handle addEventListener( const Arguments& args ) {     HandleScope scope;     if (!args[0]->IsFunction()) {         return ThrowException(Exception::TypeError(String::New("Wrong arguments")));     }      Persistent fn = Persistent::New(Handle::Cast(args[0]));     Local num = Number::New(registerListener(&callback, &fn));     scope.Close(num); } 

When an event happens, the following method is called. I'm assuming that this probably happens on another thread to which V8 is executing JS.

void callback(int event, void* context ) {     HandleScope scope;     Local args[] = { Local::New(Number::New(event)) };     Persistent *func = static_cast *>(context);     (* func)->Call((* func), 1, args);      scope.Close(Undefined()); } 

This causes a Segmentation fault: 11. Note that if I call the callback function directly with a reference to Persistent from addEventListener(), it executes the function correctly.

I'm assuming that I need a Locker or Isolate? It also looks like libuv's uv_queue_work() might be able to solve this, but since I don't start the thread, I can't see how you would use it.

回答1:

When you declare Persistent fn in your code, fn is a stack-allocated variable.

fn is a Persistent, which is a handle class, and it will contain a pointer to some heap-allocated value of type Function, but fn itself is on the stack.

This means that when you call registerListener(&callback, &fn), &fn is taking the address of the handle (type Persistent), not the address of the Function on the heap. When your function exits, the handle will be destroyed but the Function itself will remain on the heap.

So as a fix, I suggest passing the address of the Function instead of the address of the handle, like this:

Persistent fn = Persistent::New(Handle::Cast(args[0])); Local num = Number::New(registerListener(&callback, *fn)); 

(note that operator* on a Persistent returns a T* rather than the more conventional T&, c.f. http://bespin.cz/~ondras/html/classv8_1_1Handle.html)

You'll also have to adjust callback to account for the fact that context is now a raw pointer to a Function, like this:

Persistent func = static_cast(context); func->Call((* func), 1, args); 

Creating a Persistent from a raw Function pointer here is OK because we know that context is actually a persistent object.

I've also changed (*func)->Call(...) to func->Call(...) for brevity; they do the same thing for V8 handles.



回答2:

I know this question is a bit old, but there has been a pretty major update in nodejs v0.10 to v0.12. V8 changed the behavior of v8::Persistent. v8::Persistent no longer inherits from v8::Handle. I was updating some code and found that the following worked...

  void resize(const v8::FunctionCallbackInfo &args) {     Isolate *isolate = Isolate::GetCurrent();     HandleScope scope(isolate);     Persistent callback;     callback.Reset(isolate, args[0].As())     const unsigned argc = 2;     Local argv[argc] = { Null(isolate), String::NewFromUtf8(isolate, "success") };     Local::New(isolate, work->callback)->Call(isolate->GetCurrentContext()->Global(), argc, argv);     callback.Reset();   } 

I believe the goal of this update was to make it harder to expose memory leaks. In node v0.10, you would have done something like the following...

  v8::Local<:value> value = /* ... */;   v8::Persistent<:value> persistent = v8::Persistent<:value>::New(value);   // ...   v8::Local<:value> value_again = *persistent;   // ...   persistent.Dispose();   persistent.Clear(); 


回答3:

The problem is that in addEventListener, Persistent fn is allocated on the stack, and then you're taking the pointer to that to use as a context for the callback.

But, because fn is allocated on the stack, it disappears when addEventListener exits. So withing the callback context now point to some bogus value.

You should allocate some heap space, and put all the data you need in callback there.



标签
易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!