Mock request/post with mockito

匿名 (未验证) 提交于 2019-12-03 01:36:02

问题:

I am having trouble covering the following function 'postJson' with tests (JUnit/Mockito), and can't find a way to mock the line response = getTarget(path).request().post(entity, Map.class);

//Constructor public HttpService() {     this.client = ClientBuilder.newClient(); }  Client client;  public Map<String, ?> postJson(String path, Map<String, ?> data){     Map<String, ?> response = null;      try {         Entity<Map<String, ?>> entity = Entity.entity(data, MediaType.APPLICATION_JSON);         response = getTarget(path).request().post(entity, Map.class);        } catch (Exception e) {         LOG.error(e.toString());     }      return response; }  public WebTarget getTarget(String path){     return client.target(BASE_URI + path); } 

My test currently

I can't find a way to make the test code after the 'request()' onwards. Anyone can give me an example/explain how I can go about covering this function with mockito ?

回答1:

Given this additional constructor on HttpService:

public HttpService(Client client) {     this.client = client; } 

The following test will pass:

@RunWith(MockitoJUnitRunner.class) public class HttpServiceTest {      @Mock     private Client client;     @Mock     private WebTarget webTarget;     @Mock     private RequestEntity requestEntity;      private HttpService httpService;      @Before     public void setUp() {         this.httpService = new HttpService(client);     }      @Test     public void postJsonTest() {         String path = "/a/path";         Map<String, ?> data = new HashMap<>();          // the postJson method features this chained call: getTarget(path).request().post(entity, Map.class)         // so we have to mock each object created in that chain          // covers getTarget(path)         Mockito.when(client.target(Mockito.anyString())).thenReturn(webTarget);          // covers request()         Mockito.when(webTarget.request()).thenReturn(requestEntity);          // covers post()         Map<String, Object> expected = new HashMap<>();          Mockito.when(requestEntity.post(Mockito.any(Entity.class), Mockito.eq(Map.class))).thenReturn(expected);         Map<String, ?> actual = httpService.postJson(path, data);         Assert.assertSame(expected, actual);     } } 

Notes:

  • This relies on providing a new HttpService constructor which accepts a Client instance.
  • The existing approach of instancing Client via a static method call inside the HttpService's no-arg constructor requires use of PowerMockito. A more test friendly approach is to provide a constructor which accepts a Client or perhaps a ClientFactory with the default implementation of the ClientFactory being ClientBuilder.newClient()
  • The postJson() method features a chained call (getTarget(path).request().post(entity, Map.class)) which requires us to mock each object returned in that chain i.e. Client, WebTarget and RequestEntity
  • My example skates over specifics such as the generic type of RequestEntity and the choice of exact argument matchers vs. general argument matchers. You'll be able to make the right choice there since you know most about (a) the specifics of your implementation and (b) the intention of your test but the above test at least shows you that mocking a chain of calls requires each object in that chain to be mocked.


易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!